On Fri, 27 Aug 2021, J. Bruce Fields wrote: > On Thu, Aug 26, 2021 at 02:28:15PM +1000, NeilBrown wrote: > > > > File-handles not in the "new" or "version 1" format have not been handed > > out for new mounts since Linux 2.4 which was released 20 years ago. > > I think it is safe to say that no such file handles are still in use, > > and that we can drop support for them. > > > > This patch also moves the nfsfh.h from the include/uapi directory into > > fs/nfsd. I can find no evidence of it being used anywhere outside the > > kernel. Certainly nfs-utils and wireshark do not use it. > > > > fh_base and fh_pad are occasionally used to refer to the whole > > filehandle. These are replaced with "fh_raw" which is hopefully more > > meaningful. > > Oh boy, I will not miss those (fh_version == 1) cases in nfsfh.c. > Excellent. :-) > > Looks like it just needs the following folded in. Don't know how I missed those - so happy to have reliable reviewers! Thanks, NeilBrown
