Re: [PATCH v2 1/4] SUNRPC: Add a /sys/kernel/debug/fail_sunrpc/ directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chuck,

I love your patch! Yet something to improve:

[auto build test ERROR on nfs/linux-next]
[also build test ERROR on linus/master v5.14-rc5 next-20210810]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chuck-Lever/SunRPC-fault-injection/20210811-050828
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: xtensa-nommu_kc705_defconfig (attached as .config)
compiler: xtensa-de212-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/fe621cd68ac79d864276194e88bf1384505db10b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chuck-Lever/SunRPC-fault-injection/20210811-050828
        git checkout fe621cd68ac79d864276194e88bf1384505db10b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   net/sunrpc/debugfs.c: In function 'sunrpc_debugfs_init':
>> net/sunrpc/debugfs.c:346:2: error: implicit declaration of function 'fail_sunrpc_init' [-Werror=implicit-function-declaration]
     346 |  fail_sunrpc_init();
         |  ^~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/fail_sunrpc_init +346 net/sunrpc/debugfs.c

   329	
   330	void __init
   331	sunrpc_debugfs_init(void)
   332	{
   333		struct dentry *rpc_fault_dir;
   334	
   335		topdir = debugfs_create_dir("sunrpc", NULL);
   336	
   337		rpc_clnt_dir = debugfs_create_dir("rpc_clnt", topdir);
   338	
   339		rpc_xprt_dir = debugfs_create_dir("rpc_xprt", topdir);
   340	
   341		rpc_fault_dir = debugfs_create_dir("inject_fault", topdir);
   342	
   343		debugfs_create_file("disconnect", S_IFREG | 0400, rpc_fault_dir, NULL,
   344				    &fault_disconnect_fops);
   345	
 > 346		fail_sunrpc_init();

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux