Re: [PATCH/rfc v2] NFS: introduce NFS namespaces.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 8 Jul 2021 at 00:19, NeilBrown <neilb@xxxxxxx> wrote:
> sorry - my bad..
>
> I think I've found it.  Rather than sending the whole patch, here is the
> incremental fix.  But not clearing this pointer, I risk the value in it
> being freed twice.  That might lead to what you saw.
>
> Thanks,
> NeilBrown
>
>
>
> diff --git a/fs/nfs/fs_context.c b/fs/nfs/fs_context.c
> index 7c644a31d304..9e34af223ce6 100644
> --- a/fs/nfs/fs_context.c
> +++ b/fs/nfs/fs_context.c
> @@ -1451,6 +1451,7 @@ static int nfs_fs_context_dup(struct fs_context *fc, struct fs_context *src_fc)
>         ctx->nfs_server.export_path     = NULL;
>         ctx->nfs_server.hostname        = NULL;
>         ctx->fscache_uniq               = NULL;
> +       ctx->namespace                  = NULL;
>         ctx->clone_data.fattr           = NULL;
>         fc->fs_private = ctx;
>         return 0;
>

Yep, I think that has done the trick. I haven't crashed it with the
same workload yet....

I can do some more thorough testing now. Thanks!

Daire



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux