On Fri, 25 Jun 2021, Dan Carpenter wrote: > Hi NeilBrown, > > url: https://github.com/0day-ci/linux/commits/NeilBrown/NFS-introduce-NFS-namespaces/20210625-093359 > base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next > config: x86_64-randconfig-m001-20210622 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> I assume this only applies if I fix the issue with a separate patch? > > New smatch warnings: > fs/nfs/nfs4proc.c:6270 nfs4_init_uniform_client_string() error: we previously assumed 'clp->cl_namespace' could be null (see line 6247) > > Old smatch warnings: > fs/nfs/nfs4proc.c:1382 nfs4_opendata_alloc() error: we previously assumed 'c' could be null (see line 1350) > ... > 0575ca34891617 NeilBrown 2021-06-25 @6247 if (clp->cl_namespace) > ^^^^^^^^^^^^^^^^^^^^^^ > Checks for NULL Thanks. That was suppose to check the first byte of clp->cl_namespace, not the pointer. Thanks, NeilBrown
