From: "J. Bruce Fields" <bfields@xxxxxxxxxx> The following fix up some problems that can cause crashes or silently broken lock guarantees in the reexport case. Not fixed: - Attempts to reclaim locks after a reboot of the reexport server will fail. This at least seems like an improvement over the current situation, which is that they'll succeed even in cases where they shouldn't. Complete support for reboot recovery is a bigger job. - NFSv4.1+ lock nofications don't work. So, clients have to poll as they do with NFSv4.0, which is suboptimal, but correct (and an improvement over the current situation, which is a kernel oops). So what we have at this point is a suboptimal lock implementation that doesn't support lock recovery. Another alternative might be to turn off file locking entirely in the re-export case. I'd rather take the incremental improvement and fix the oopses. --b. J. Bruce Fields (3): nfs: don't atempt blocking locks on nfs reexports lockd: lockd server-side shouldn't set fl_ops nfs: don't allow reexport reclaims fs/lockd/svclock.c | 30 ++++++++++++------------------ fs/nfs/export.c | 2 +- fs/nfs/file.c | 3 +++ fs/nfsd/nfs4state.c | 11 +++++++++-- fs/nfsd/nfsproc.c | 1 + include/linux/exportfs.h | 2 ++ include/linux/fs.h | 1 + 7 files changed, 29 insertions(+), 21 deletions(-) -- 2.31.1
