Hi Steve, all, > Hey! > On 5/17/21 12:45 AM, NeilBrown wrote: > > Some filesystems cannot be exported without an fsid or uuid. > > tmpfs is the main example. > > When mountd (or exportd) creates nfsv4 pseudo-root exports for the path > > leading down to an export point it exports each directory without any > > fsid or uuid. If one of these directories is on tmp, that will fail. > > The net result is that exporting a subdirectory of a tmpfs filesystem > > will not work over NFSv4 as the parents within the filesystem cannot be > > exported. It will either fail, or fall-back to NFSv3 (depending on the > > version of the mount.nfs program). > > To fix this we need to provide an fsid or uuid for these pseudo-root > > exports. This patch does that by creating an RFC-4122 V5 compatible > > UUID based on an arbitrary seed and the path to the export. > > To check if an export needs a uuid, text_export() is moved from exportfs > > to libexport.a, modified slightly and renamed to export_test(). > Well.... it appears you guys did not compile with the --with-systemd > config flag... Because if you did you would have seeing this compile error > the in systemd code: You're right, I didn't :(. > /usr/bin/ld: ../support/nfs/.libs/libnfs.a(cacheio.o): in function `stat': > /usr/include/sys/stat.h:455: undefined reference to `etab' > collect2: error: ld returned 1 exit status > make[1]: *** [Makefile:560: nfs-server-generator] Error 1 > make[1]: Leaving directory '/home/src/up/nfs-utils/systemd' > make: *** [Makefile:479: all-recursive] Error 1 > It turns out the moving of export_test() in to the libexport.a > is causing any binary linking with libexport.a to have a > global definition of struct state_paths etab; > The reason is export_test() calls qword_add(). Now qword_add() > does not use an etab, but the file qword_add() lives in is > cacheio.c which does have a extern struct state_paths etab > which is the reason libnfs.a(cacheio.o) is mentioned in > the error. At least that is what I *think* is going on... > The extern came from commit a15bd94. > Now the work around is to simply define a > struct state_paths etab; in nfs-server-generator.c > which will not be used at least by the systemd code. > Now is that something we want continue doing... make any > binaries linking with libexport.a define a global etab. > It seems a little messy but the interface is not documented > and the alternative, moving a bunch of code around see a lot > more messy that simple adding one definition. +1 Kind regards, Petr > Other than not compiling... Things looks good! ;-) > Thoughts? > steved. ...
