Re: [PATCH] nfsd: Prevent truncation of an unlinked inode from blocking access to its directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] nfsd: Prevent truncation of an unlinked inode from blocking access to its directory
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 15 May 2021 08:02:39 +0100
Cc: "bfields@xxxxxxxxxxxx" <bfields@xxxxxxxxxxxx>, "nickhuang@xxxxxxxxxxxx" <nickhuang@xxxxxxxxxxxx>, "chuck.lever@xxxxxxxxxx" <chuck.lever@xxxxxxxxxx>, "robbieko@xxxxxxxxxxxx" <robbieko@xxxxxxxxxxxx>, "bingjingc@xxxxxxxxxxxx" <bingjingc@xxxxxxxxxxxx>, "linux-nfs@xxxxxxxxxxxxxxx" <linux-nfs@xxxxxxxxxxxxxxx>
In-reply-to: <00195ec8bf1752306f549540eed74c3938c5e312.camel@hammerspace.com>
References: <20210514035829.5230-1-nickhuang@synology.com> <00195ec8bf1752306f549540eed74c3938c5e312.camel@hammerspace.com>

On Fri, May 14, 2021 at 03:46:57PM +0000, Trond Myklebust wrote:
> Why leave the commit_metadata() call under the lock? If you're
> concerned about latency, then it makes more sense to call fh_unlock()
> before flushing those metadata updates to disk.

Also I'm not sure why the extra inode reference is needed.  What speaks
against just moving the dput out of the locked section?

Follow-Ups:
- Re: [PATCH] nfsd: Prevent truncation of an unlinked inode from blocking access to its directory
  - From: Trond Myklebust
- Re: [PATCH] nfsd: Prevent truncation of an unlinked inode from blocking access to its directory
  - From: bfields@xxxxxxxxxxxx

References:
- [PATCH] nfsd: Prevent truncation of an unlinked inode from blocking access to its directory
  - From: Nick Huang
- Re: [PATCH] nfsd: Prevent truncation of an unlinked inode from blocking access to its directory
  - From: Trond Myklebust

Prev by Date: Re: [PATCH v4 1/2] NFSD: delay unmount source's export after inter-server copy completed.
Next by Date: Re: [PATCH v7 10/12] sunrpc: add dst_attr attributes to the sysfs xprt directory
Previous by thread: Re: [PATCH] nfsd: Prevent truncation of an unlinked inode from blocking access to its directory
Next by thread: Re: [PATCH] nfsd: Prevent truncation of an unlinked inode from blocking access to its directory
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystem Development] [Linux USB Development] [Linux Media Development] [Video for Linux] [Linux NILFS] [Linux Audio Users] [Yosemite Info] [Linux SCSI]