Re: [PATCH v2 01/25] NFSD: Fix TP_printk() format specifier in trace_nfsd_dirent()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On May 13, 2021, at 3:00 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> 
> On Thu, 13 May 2021 18:43:29 +0000
> Chuck Lever III <chuck.lever@xxxxxxxxxx> wrote:
> 
>>>> Would something like that work?  
>>> 
>>> I will test later today and let you know in this thread.  
>> 
>> All good.
>> 
>> Tested-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
> 
> Thanks, since this is an enhancement and not a fix, it will need to wait
> till the next merge window to go in.
> 
> I can write up a formal patch and let you add it to this patch set as the
> first patch, or I can add it to my tree if you don't expect this to get
> into the next merge window.

The tracepoints that currently use '%.*s' no longer work when
using "trace-cmd start/stop/show". They were working before
9a6944fee68e, so I consider this a regression. I plan to
submit patches to address this for 5.13-rc. I guess they will
have to go without the use of the new _len macros for now,
and you can push the macros in v5.14.


--
Chuck Lever







[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux