On Mon, May 10, 2021 at 11:51 AM Chuck Lever <chuck.lever@xxxxxxxxxx> wrote: > > Happy Monday. > > I've hacked together some improvements to the tracepoints that record > server callback and lease management activity. I'm interested in > review comments and testing. I'm sure I've missed your favorite edge > case, so please let me know what it is! > I will take a look at these, especially with an eye towards some of the recent discussions about duplicate client ids. Building now (against 5.13-rc1). Thanks Chuck! > --- > > Chuck Lever (21): > NFSD: Constify @fh argument of knfsd_fh_hash() > NFSD: Capture every CB state transition > NFSD: Drop TRACE_DEFINE_ENUM for NFSD4_CB_<state> macros > NFSD: Add cb_lost tracepoint > NFSD: Adjust cb_shutdown tracepoint > NFSD: Remove spurious cb_setup_err tracepoint > NFSD: Enhance the nfsd_cb_setup tracepoint > NFSD: Add an nfsd_cb_lm_notify tracepoint > NFSD: Add an nfsd_cb_offload tracepoint > NFSD: Replace the nfsd_deleg_break tracepoint > NFSD: Add an nfsd_cb_probe tracepoint > NFSD: Remove the nfsd_cb_work and nfsd_cb_done tracepoints > NFSD: Update nfsd_cb_args tracepoint > NFSD: Add nfsd_clid_cred_mismatch tracepoint > NFSD: Add nfsd_clid_verf_mismatch tracepoint > NFSD: Remove nfsd_clid_inuse_err > NFSD: Add nfsd_clid_confirmed tracepoint > NFSD: Add nfsd_clid_destroyed tracepoint > NFSD: Add a couple more nfsd_clid_expired call sites > NFSD: Rename nfsd_clid_class > NFSD: Add tracepoints to observe clientID activity > > > fs/nfsd/nfs4callback.c | 45 ++++---- > fs/nfsd/nfs4proc.c | 1 + > fs/nfsd/nfs4state.c | 56 +++++++--- > fs/nfsd/nfsfh.h | 7 +- > fs/nfsd/trace.h | 227 ++++++++++++++++++++++++++++++++++------- > 5 files changed, 254 insertions(+), 82 deletions(-) > > -- > Chuck Lever >