On Tue, May 4, 2021 at 12:09 AM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Mon, May 03, 2021 at 11:56:41PM +0300, Andy Shevchenko wrote: > > On Mon, May 3, 2021 at 11:54 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > > > > > On Mon, May 03, 2021 at 11:49:05PM +0300, Andy Shevchenko wrote: > > > > string_escape_mem_ascii() followed by seq_escape_mem_ascii() is completely > > > > non-flexible and shouldn't be exist from day 1. > > > > > > > > Replace it with properly called string_escape_mem(). > > > > > > NAKed-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > > > > > Reason: use of seq_get_buf(). Which should have been static inline in > > > fs/seq_file.c, to start with. > > > > I see. > > > > > Again, any new uses of seq_get_buf()/seq_commit() are grounds for automatic > > > NAK. These interfaces *will* be withdrawn. > > > > You meant that this is no way to get rid of this guy? > > Any suggestions how to replace that API with a newer one? > > seq_escape_mem(), perhaps? I think I have a better idea. What about adding seq_escape_with_flags() and seq_escape() --> seq_escape_with_flags(..., ESCAPE_OCTAL, ...) ? Would it work for you? -- With Best Regards, Andy Shevchenko
