On Fri, Apr 23, 2021 at 08:25:28PM +0300, Leon Romanovsky wrote:
> On Thu, Apr 22, 2021 at 03:39:50PM -0400, J. Bruce Fields wrote:
> > On Wed, Apr 21, 2021 at 09:56:37AM -0400, J. Bruce Fields wrote:
> > > On Wed, Apr 21, 2021 at 04:49:31PM +0300, Leon Romanovsky wrote:
> > > > If you want to see another accepted patch that is already part of
> > > > stable@, you are invited to take a look on this patch that has "built-in bug":
> > > > 8e949363f017 ("net: mlx5: Add a missing check on idr_find, free buf")
> > >
> > > Interesting, thanks.
> >
> > Though looking at it now, I'm not actually seeing the bug--probably I'm
> > overlooking something obvious.
>
> It was fixed in commit 31634bf5dcc4 ("net/mlx5: FPGA, tls, hold rcu read lock a bit longer")
So is the "Fixes:" line on that commit wrong? It claims the bug was
introduced by an earlier commit, ab412e1dd7db ("net/mlx5: Accel, add TLS
rx offload routines").
Looks like Aditya Pakki's commit may have widened the race a little, but
I find it a little hard to fault him for that.
--b.
