On Wed, Apr 14, 2021 at 10:40:33AM -0400, bfields wrote: > Thanks! Testing.... ... and, test results back with these two patches applied, looks good! --b. > > --b. > > On Wed, Apr 14, 2021 at 10:31:38AM -0400, trondmy@xxxxxxxxxx wrote: > > From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> > > > > When a copy offload is performed, we do not expect the source file to > > change other than perhaps to see the atime be updated. > > > > Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> > > --- > > fs/nfs/nfs42proc.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c > > index 3875120ef3ef..a24349512ffe 100644 > > --- a/fs/nfs/nfs42proc.c > > +++ b/fs/nfs/nfs42proc.c > > @@ -390,12 +390,7 @@ static ssize_t _nfs42_proc_copy(struct file *src, > > } > > > > nfs42_copy_dest_done(dst_inode, pos_dst, res->write_res.count); > > - > > - spin_lock(&src_inode->i_lock); > > - nfs_set_cache_invalid(src_inode, NFS_INO_REVAL_PAGECACHE | > > - NFS_INO_REVAL_FORCED | > > - NFS_INO_INVALID_ATIME); > > - spin_unlock(&src_inode->i_lock); > > + nfs_invalidate_atime(src_inode); > > status = res->write_res.count; > > out: > > if (args->sync) > > -- > > 2.30.2
