> On Mar 12, 2021, at 4:03 PM, Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote:
>
> `printk()`, by default, uses the log level warning, which leaves the
> user reading
>
> NFSD: Using UMH upcall client tracking operations.
>
> wondering what to do about it (`dmesg --level=warn`).
>
> Several client tracking methods are tried, and expected to fail. That’s
> why a message is printed only on success. It might be interesting for
> users to know the chosen method, so use info-level instead of
> debug-level.
>
> Cc: linux-nfs@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
Hi Paul, I've included your patch in the for-next topic branch at
git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
> ---
> v4: Remove error message, and use info-level, as several client tracking
> methods are tried.
>
> fs/nfsd/nfs4recover.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> index 891395c6c7d3..6fedc49726bf 100644
> --- a/fs/nfsd/nfs4recover.c
> +++ b/fs/nfsd/nfs4recover.c
> @@ -626,7 +626,7 @@ nfsd4_legacy_tracking_init(struct net *net)
> status = nfsd4_load_reboot_recovery_data(net);
> if (status)
> goto err;
> - printk("NFSD: Using legacy client tracking operations.\n");
> + pr_info("NFSD: Using legacy client tracking operations.\n");
> return 0;
>
> err:
> @@ -1028,7 +1028,7 @@ nfsd4_init_cld_pipe(struct net *net)
>
> status = __nfsd4_init_cld_pipe(net);
> if (!status)
> - printk("NFSD: Using old nfsdcld client tracking operations.\n");
> + pr_info("NFSD: Using old nfsdcld client tracking operations.\n");
> return status;
> }
>
> @@ -1605,7 +1605,7 @@ nfsd4_cld_tracking_init(struct net *net)
> nfs4_release_reclaim(nn);
> goto err_remove;
> } else
> - printk("NFSD: Using nfsdcld client tracking operations.\n");
> + pr_info("NFSD: Using nfsdcld client tracking operations.\n");
> return 0;
>
> err_remove:
> @@ -1864,7 +1864,7 @@ nfsd4_umh_cltrack_init(struct net *net)
> ret = nfsd4_umh_cltrack_upcall("init", NULL, grace_start, NULL);
> kfree(grace_start);
> if (!ret)
> - printk("NFSD: Using UMH upcall client tracking operations.\n");
> + pr_info("NFSD: Using UMH upcall client tracking operations.\n");
> return ret;
> }
>
> --
> 2.30.2
>
--
Chuck Lever
