Re: [PATCH v1 01/42] NFSD: Extract the svcxdr_init_encode() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Mar 2, 2021, at 11:47 AM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote:
> 
> On Mon, Mar 01, 2021 at 10:15:24AM -0500, Chuck Lever wrote:
>> NFSD initializes an encode xdr_stream only after the RPC layer has
>> already inserted the RPC Reply header.
> 
> Out of curiosity: does it need to be this way?

The code in svc.c uses the old-school svc_putu32() and friends macros.
I don't think there's another reason.

IMHO they could be replaced, but I didn't have the stones to go that
far.


--
Chuck Lever







[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux