On Thu, Feb 18, 2021 at 9:42 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > Looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > This whole idea of cross-device copie has always been a horrible idea, > and I've been arguing against it since the patches were posted. Ok. I'm good with this v2 as well, but need to add the fallback to do_splice_direct() in nfsd_copy_file_range(), because this patch breaks it. And the commit message of v3 is better in describing the reported issue. Thanks, Amir.
