Re: [PATCH] NFSv4_2: SSC helper should use its own config.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dai,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nfs/linux-next]
[also build test ERROR on linus/master nfsd/nfsd-next v5.11-rc5 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Dai-Ngo/NFSv4_2-SSC-helper-should-use-its-own-config/20210124-141002
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: x86_64-kexec (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/39c41233a1cdc4dc2d2a690293049510d384a2b2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dai-Ngo/NFSv4_2-SSC-helper-should-use-its-own-config/20210124-141002
        git checkout 39c41233a1cdc4dc2d2a690293049510d384a2b2
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   ld: fs/nfs/super.o: in function `nfs_ssc_register_ops':
   fs/nfs/super.c:120: undefined reference to `nfs_ssc_register'
   ld: fs/nfs/super.o: in function `nfs_ssc_unregister_ops':
   fs/nfs/super.c:127: undefined reference to `nfs_ssc_unregister'
   ld: fs/nfs/nfs4file.o: in function `nfs42_ssc_register_ops':
>> fs/nfs/nfs4file.c:424: undefined reference to `nfs42_ssc_register'
   ld: fs/nfs/nfs4file.o: in function `nfs42_ssc_unregister_ops':
>> fs/nfs/nfs4file.c:437: undefined reference to `nfs42_ssc_unregister'


vim +424 fs/nfs/nfs4file.c

0cfcd405e758ba Dai Ngo           2020-10-18  414  
0cfcd405e758ba Dai Ngo           2020-10-18  415  /**
0cfcd405e758ba Dai Ngo           2020-10-18  416   * nfs42_ssc_register_ops - Wrapper to register NFS_V4 ops in nfs_common
0cfcd405e758ba Dai Ngo           2020-10-18  417   *
0cfcd405e758ba Dai Ngo           2020-10-18  418   * Return values:
0cfcd405e758ba Dai Ngo           2020-10-18  419   *   None
0cfcd405e758ba Dai Ngo           2020-10-18  420   */
0cfcd405e758ba Dai Ngo           2020-10-18  421  void nfs42_ssc_register_ops(void)
0cfcd405e758ba Dai Ngo           2020-10-18  422  {
39c41233a1cdc4 Dai Ngo           2021-01-22  423  #ifdef CONFIG_NFSD_V4
0cfcd405e758ba Dai Ngo           2020-10-18 @424  	nfs42_ssc_register(&nfs4_ssc_clnt_ops_tbl);
39c41233a1cdc4 Dai Ngo           2021-01-22  425  #endif
0cfcd405e758ba Dai Ngo           2020-10-18  426  }
0cfcd405e758ba Dai Ngo           2020-10-18  427  
0cfcd405e758ba Dai Ngo           2020-10-18  428  /**
0cfcd405e758ba Dai Ngo           2020-10-18  429   * nfs42_ssc_unregister_ops - wrapper to un-register NFS_V4 ops in nfs_common
0cfcd405e758ba Dai Ngo           2020-10-18  430   *
0cfcd405e758ba Dai Ngo           2020-10-18  431   * Return values:
0cfcd405e758ba Dai Ngo           2020-10-18  432   *   None.
0cfcd405e758ba Dai Ngo           2020-10-18  433   */
0cfcd405e758ba Dai Ngo           2020-10-18  434  void nfs42_ssc_unregister_ops(void)
0cfcd405e758ba Dai Ngo           2020-10-18  435  {
39c41233a1cdc4 Dai Ngo           2021-01-22  436  #ifdef CONFIG_NFSD_V4
0cfcd405e758ba Dai Ngo           2020-10-18 @437  	nfs42_ssc_unregister(&nfs4_ssc_clnt_ops_tbl);
39c41233a1cdc4 Dai Ngo           2021-01-22  438  #endif
0cfcd405e758ba Dai Ngo           2020-10-18  439  }
6b7153da2c1a58 Christoph Hellwig 2015-11-13  440  #endif /* CONFIG_NFS_V4_2 */
bea51b30b28103 Peng Tao          2015-09-26  441  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux