----- Original Message ----- > From: "trondmy" <trondmy@xxxxxxxxxxxxxxx> > To: "Tigran Mkrtchyan" <tigran.mkrtchyan@xxxxxxx>, "linux-nfs" <linux-nfs@xxxxxxxxxxxxxxx> > Cc: "Anna Schumaker" <anna.schumaker@xxxxxxxxxx> > Sent: Thursday, 10 December, 2020 15:42:38 > Subject: Re: [PATCH] nfs41: update ff_layout_io_track_ds_error to accept rpc task > Hi Tigran, > > On Thu, 2020-12-10 at 10:55 +0000, Tigran Mkrtchyan wrote: >> When debugging READ_PLUS issues sent to DS I noticed that layoutstats >> was reporting READ, though READ_PLUS was used. >> >> The ff_layout_io_track_ds_error function takes the 'major' opnum as >> an >> argumentas well as the corresponding resulting error code. >> >> By passing rpc task as an argument, the bogh values can be extracted >> insideff_layout_io_track_ds_error and reduce a possibility of calling >> with incorrect opnum. > > I think we just want to disable READ_PLUS support in pNFS for the > moment. We have no way of discovering and tracking whether or not the > DS actually supports it, so let's leave it out for now. No objections. Tigran. > > -- > Trond Myklebust > Linux NFS client maintainer, Hammerspace > trond.myklebust@xxxxxxxxxxxxxxx
