Hi, I love your patch! Yet something to improve: [auto build test ERROR on nfs/linux-next] [also build test ERROR on v5.10-rc5 next-20201125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/trondmy-kernel-org/NFSv4-Fix-a-pNFS-layout-related-use-after-free-race-when-freeing-the-inode/20201126-025547 base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next config: i386-randconfig-s001-20201125 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-151-g540c2c4b-dirty # https://github.com/0day-ci/linux/commit/1152b7349ba4ede4340756f56f5f21808d987a86 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review trondmy-kernel-org/NFSv4-Fix-a-pNFS-layout-related-use-after-free-race-when-freeing-the-inode/20201126-025547 git checkout 1152b7349ba4ede4340756f56f5f21808d987a86 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): fs/nfs/nfs4super.c: In function 'nfs4_evict_inode': >> fs/nfs/nfs4super.c:70:2: error: implicit declaration of function 'pnfs_destroy_layout_final'; did you mean 'pnfs_destroy_layout'? [-Werror=implicit-function-declaration] 70 | pnfs_destroy_layout_final(NFS_I(inode)); | ^~~~~~~~~~~~~~~~~~~~~~~~~ | pnfs_destroy_layout cc1: some warnings being treated as errors vim +70 fs/nfs/nfs4super.c 56 57 /* 58 * Clean out any remaining NFSv4 state that might be left over due 59 * to open() calls that passed nfs_atomic_lookup, but failed to call 60 * nfs_open(). 61 */ 62 static void nfs4_evict_inode(struct inode *inode) 63 { 64 truncate_inode_pages_final(&inode->i_data); 65 clear_inode(inode); 66 /* If we are holding a delegation, return and free it */ 67 nfs_inode_evict_delegation(inode); 68 /* Note that above delegreturn would trigger pnfs return-on-close */ 69 pnfs_return_layout(inode); > 70 pnfs_destroy_layout_final(NFS_I(inode)); 71 /* First call standard NFS clear_inode() code */ 72 nfs_clear_inode(inode); 73 nfs4_xattr_cache_zap(inode); 74 } 75 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
