On Tue, 2020-11-24 at 15:26 -0500, J. Bruce Fields wrote: > On Tue, Nov 24, 2020 at 11:18:09AM -0500, J. Bruce Fields wrote: > > On Tue, Nov 24, 2020 at 11:12:50AM -0500, bfields wrote: > > > On Tue, Nov 24, 2020 at 08:50:16AM -0500, > > > trondmy@xxxxxxxxxx wrote: > > > > From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> > > > > > > > > When looking at the issues raised by Tigran's testing of the > > > > NFS client > > > > updates, I noticed a couple of things in the generic SUNRPC xdr > > > > code > > > > that want to be fixed. This patch series replaces an earlier > > > > series that > > > > attempted to just fix the XDR padding in the NFS code. > > > > > > > > This series fixes up a number of issues w.r.t. bounds checking > > > > in the > > > > xdr_stream code. It corrects the behaviour of xdr_read_pages() > > > > for the > > > > case where the XDR object size is larger than the buffer page > > > > array > > > > length and simplifies the code. > > > > > > I'm seeing this on the client with recent upstream + these > > > patches. > > > > Unfortunately that was in the middle of a series of tests, and I'm > > not > > sure exactly what triggered it--I'm guessing cthon special over > > krb5i. > > I'll let you know what else I can figure out. > > Yeah, reproduceable by running cthon -s over krb5i, and it first > shows > up with the last patch, "NFSv4.2: Fix up read_plus() page alignment". OK, thanks! I'll just drop that one then. I don't think it really suffices to fix READ_PLUS as it stands. -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@xxxxxxxxxxxxxxx
