Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> --- fs/nfsd/nfs4xdr.c | 35 +++++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index 7ef6baf9c3b7..c48fa1427421 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -1861,24 +1861,31 @@ static __be32 nfsd4_decode_layoutget(struct nfsd4_compoundargs *argp, struct nfsd4_layoutget *lgp) { - DECODE_HEAD; - - READ_BUF(36); - lgp->lg_signal = be32_to_cpup(p++); - lgp->lg_layout_type = be32_to_cpup(p++); - lgp->lg_seg.iomode = be32_to_cpup(p++); - p = xdr_decode_hyper(p, &lgp->lg_seg.offset); - p = xdr_decode_hyper(p, &lgp->lg_seg.length); - p = xdr_decode_hyper(p, &lgp->lg_minlength); + __be32 status; + if (xdr_stream_decode_u32(argp->xdr, &lgp->lg_signal) < 0) + goto xdr_error; + if (xdr_stream_decode_u32(argp->xdr, &lgp->lg_layout_type) < 0) + goto xdr_error; + if (xdr_stream_decode_u32(argp->xdr, &lgp->lg_seg.iomode) < 0) + goto xdr_error; + if (xdr_stream_decode_u64(argp->xdr, &lgp->lg_seg.offset) < 0) + goto xdr_error; + if (xdr_stream_decode_u64(argp->xdr, &lgp->lg_seg.length) < 0) + goto xdr_error; + if (xdr_stream_decode_u64(argp->xdr, &lgp->lg_minlength) < 0) + goto xdr_error; status = nfsd4_decode_stateid4(argp, &lgp->lg_sid); if (status) - return status; - - READ_BUF(4); - lgp->lg_maxcount = be32_to_cpup(p++); + goto out; + if (xdr_stream_decode_u32(argp->xdr, &lgp->lg_maxcount) < 0) + goto xdr_error; - DECODE_TAIL; + status = nfs_ok; +out: + return status; +xdr_error: + return nfserr_bad_xdr; } static __be32