Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> --- fs/nfsd/nfs4xdr.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index 71a9bdb67d06..db63cd46b9b1 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -1387,22 +1387,27 @@ nfsd4_decode_verify(struct nfsd4_compoundargs *argp, struct nfsd4_verify *verify static __be32 nfsd4_decode_write(struct nfsd4_compoundargs *argp, struct nfsd4_write *write) { - DECODE_HEAD; + __be32 status; status = nfsd4_decode_stateid4(argp, &write->wr_stateid); if (status) - return status; - READ_BUF(16); - p = xdr_decode_hyper(p, &write->wr_offset); - write->wr_stable_how = be32_to_cpup(p++); + goto out; + if (xdr_stream_decode_u64(argp->xdr, &write->wr_offset) < 0) + goto xdr_error; + if (xdr_stream_decode_u32(argp->xdr, &write->wr_stable_how) < 0) + goto xdr_error; if (write->wr_stable_how > NFS_FILE_SYNC) goto xdr_error; - write->wr_buflen = be32_to_cpup(p++); - + if (xdr_stream_decode_u32(argp->xdr, &write->wr_buflen) < 0) + goto xdr_error; if (!xdr_stream_subsegment(argp->xdr, &write->wr_payload, write->wr_buflen)) goto xdr_error; - DECODE_TAIL; + status = nfs_ok; +out: + return status; +xdr_error: + return nfserr_bad_xdr; } static __be32