On 4 Nov 2020, at 12:04, Trond Myklebust wrote: > Hi Ben > > Thanks for the review and the testing! Thank /you/ for the work! > You're right that I had screwed up the page access marking in the > previous patchsets. I believe this should be fixed in v3 by the > conversion to use grab_cache_page(), which calls find_or_create_page() > and should therefore do the right thing with the FGP_ACCESSED flag. > > I believe the reason why your patch above fails to fully correct the > issue is because we always want to mark the page as accessed if we've > scanned it. Ah, that make sense. I'll take the v3 for a ride tomorrow morning. Ben