Re: [PATCH 1/2 v3] NFSv4: Fix a livelock when CLOSE pre-emptively bumps state sequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-09-23 at 15:46 -0400, Benjamin Coddington wrote:
> On 23 Sep 2020, at 15:39, Trond Myklebust wrote:
> > The client can't predict what is going to happen w.r.t. an OPEN
> > call.
> > If it does an open by name, it doesn't even know which file is
> > going to
> > get opened. That's why we have the wait loop
> > in nfs_set_open_stateid_locked(). Why should we not do the same in
> > CLOSE and OPEN_DOWNGRADE? It's the same problem.
> 
> I will give it a shot.  In the meantime, please consider adding this
> patch
> which fixes a real bug today.  Thank you for your excellent advice
> and time.
> 

I don't think we should take that patch, and certainly not as a stable
patch. I'd prefer to wait for the real fix.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@xxxxxxxxxxxxxxx






[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux