Re: [PATCH] NFSD: Correct type annotations in user xattr helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 27, 2020 at 07:37:01PM -0400, Chuck Lever wrote:
> 
> 
> Squelch some sparse warnings:
> 
> /home/cel/src/linux/linux/fs/nfsd/vfs.c:2264:13: warning: incorrect type in assignment (different base types)
> /home/cel/src/linux/linux/fs/nfsd/vfs.c:2264:13:    expected int err
> /home/cel/src/linux/linux/fs/nfsd/vfs.c:2264:13:    got restricted __be32
> /home/cel/src/linux/linux/fs/nfsd/vfs.c:2266:24: warning: incorrect type in return expression (different base types)
> /home/cel/src/linux/linux/fs/nfsd/vfs.c:2266:24:    expected restricted __be32
> /home/cel/src/linux/linux/fs/nfsd/vfs.c:2266:24:    got int err
> /home/cel/src/linux/linux/fs/nfsd/vfs.c:2288:13: warning: incorrect type in assignment (different base types)
> /home/cel/src/linux/linux/fs/nfsd/vfs.c:2288:13:    expected int err
> /home/cel/src/linux/linux/fs/nfsd/vfs.c:2288:13:    got restricted __be32
> /home/cel/src/linux/linux/fs/nfsd/vfs.c:2290:24: warning: incorrect type in return expression (different base types)
> /home/cel/src/linux/linux/fs/nfsd/vfs.c:2290:24:    expected restricted __be32
> /home/cel/src/linux/linux/fs/nfsd/vfs.c:2290:24:    got int err
> 
> Fixes: 32119446bb65 ("nfsd: define xattr functions to call into their vfs counterparts")
> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
> ---

Thanks.. sorry about that, one of those "I could have sworn I took care of
those" cases.

- Frank



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux