Hello, On 7/1/20 2:27 PM, Doug Nazar wrote: > Signed-off-by: Doug Nazar <nazard@xxxxxxxx> > --- > utils/gssd/krb5_util.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c > index c49c6672..b1e48241 100644 > --- a/utils/gssd/krb5_util.c > +++ b/utils/gssd/krb5_util.c > @@ -484,7 +484,7 @@ gssd_get_single_krb5_cred(krb5_context context, > if (ccache) > krb5_cc_close(context, ccache); > krb5_free_cred_contents(context, &my_creds); > - krb5_free_string(context, k5err); > + free(k5err); > return (code); > } > > @@ -723,7 +723,7 @@ gssd_search_krb5_keytab(krb5_context context, krb5_keytab kt, > "we failed to unparse principal name: %s\n", > k5err); > k5_free_kt_entry(context, kte); > - krb5_free_string(context, k5err); > + free(k5err); > k5err = NULL; > continue; > } > @@ -770,7 +770,7 @@ gssd_search_krb5_keytab(krb5_context context, krb5_keytab kt, > if (retval < 0) > retval = 0; > out: > - krb5_free_string(context, k5err); > + free(k5err); > return retval; > } > > @@ -927,7 +927,7 @@ find_keytab_entry(krb5_context context, krb5_keytab kt, > k5err = gssd_k5_err_msg(context, code); > printerr(1, "%s while building principal for '%s'\n", > k5err, spn); > - krb5_free_string(context, k5err); > + free(k5err); > k5err = NULL; > continue; > } > @@ -937,7 +937,7 @@ find_keytab_entry(krb5_context context, krb5_keytab kt, > k5err = gssd_k5_err_msg(context, code); > printerr(3, "%s while getting keytab entry for '%s'\n", > k5err, spn); > - krb5_free_string(context, k5err); > + free(k5err); > k5err = NULL; > /* > * We tried the active directory machine account > @@ -986,7 +986,7 @@ out: > k5_free_default_realm(context, default_realm); > if (realmnames) > krb5_free_host_realm(context, realmnames); > - krb5_free_string(context, k5err); > + free(k5err); > return retval; > } > > @@ -1355,7 +1355,7 @@ out_free_kt: > out_free_context: > krb5_free_context(context); > out: > - krb5_free_string(context, k5err); > + free(k5err); > return retval; > } > > I'm curious about these changes... since all krb5_free_string() does is call free()... where is the "strdup'd msg" coming from? steved.
