[PATCH v3 00/10] server side user xattr support (RFC 8276)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



v3:
  * Rebase to v5.8-rc2
  * Use length probe + allocate + query for the listxattr and setxattr
    operations to avoid allocating unneeded space.
  * Because of the above, drop the 'use kvmalloc for svcxdr_tmpalloc' patch,
    as it's no longer needed.

v2:
  * As per the discussion, user extended attributes are enabled if
    the client and server support them (e.g. they support 4.2 and
    advertise the user extended attribute FATTR). There are no longer
    options to switch them off.
  * The code is no longer conditioned on a config option.
  * The number of patches has been reduced somewhat by merging
    smaller, related ones.
  * Renamed some functions and added parameter comments as requested.

v1:

  * Split in to client and server (changed from the original RFC patch).

Original RFC combined set is here:

https://www.spinics.net/lists/linux-nfs/msg74843.html

In general, these patches were, both server and client, tested as
follows:
	* stress-ng-xattr with 1000 workers
	* Test all corner cases (XATTR_SIZE_*)
	* Test all failure cases (no xattr, setxattr with different or
	  invalid flags, etc).
	* Verify the content of xattrs across several operations.
	* Use KASAN and KMEMLEAK for a longer mix of testruns to verify
	  that there were no leaks (after unmounting the filesystem).
 	* Interop run against FreeBSD server/client implementation.
 	* Ran xfstests-dev, with no unexpected/new failures as compared
	  to an unpatched kernel. To fully use xfstests-dev, it needed
	  some modifications, as it expects to either use all xattr
	  namespaces, or none. Whereas NFS only suppors the "user."
	  namespace (+ optional ACLs). I will send the changes in
	  seperately.


Frank van der Linden (10):
  xattr: break delegations in {set,remove}xattr
  xattr: add a function to check if a namespace is supported
  nfs,nfsd: NFSv4.2 extended attribute protocol definitions
  nfsd: split off the write decode code in to a separate function
  nfsd: add defines for NFSv4.2 extended attribute support
  nfsd: define xattr functions to call in to their vfs counterparts
  nfsd: take xattr bits in to account for permission checks
  nfsd: add structure definitions for xattr requests / responses
  nfsd: implement the xattr functions and en/decode logic
  nfsd: add fattr support for user extended attributes

 fs/nfsd/nfs4proc.c        | 128 ++++++++-
 fs/nfsd/nfs4xdr.c         | 531 +++++++++++++++++++++++++++++++++++---
 fs/nfsd/nfsd.h            |   5 +-
 fs/nfsd/vfs.c             | 239 +++++++++++++++++
 fs/nfsd/vfs.h             |  10 +
 fs/nfsd/xdr4.h            |  31 +++
 fs/xattr.c                | 111 +++++++-
 include/linux/nfs4.h      |  22 +-
 include/linux/xattr.h     |   4 +
 include/uapi/linux/nfs4.h |   3 +
 10 files changed, 1044 insertions(+), 40 deletions(-)

-- 
2.17.2




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux