________________________________________ From: linux-nfs-owner@xxxxxxxxxxxxxxx <linux-nfs-owner@xxxxxxxxxxxxxxx> on behalf of J. Bruce Fields <bfields@xxxxxxxxxxxx> Sent: Thursday, June 11, 2020 4:09 PM To: Schumaker, Anna Cc: olga.kornievskaia@xxxxxxxxx; trondmy@xxxxxxxxxxxxxxx; linux-nfs@xxxxxxxxxxxxxxx; steved@xxxxxxxxxx Subject: Re: [PATCH 1/1] NFSv4.0 allow nconnect for v4.0 CAUTION: This email originated from outside of the University of Guelph. Do not click links or open attachments unless you recognize the sender and know the content is safe. If in doubt, forward suspicious emails to IThelp@xxxxxxxxxxx On Fri, Jan 17, 2020 at 09:16:54PM +0000, Schumaker, Anna wrote: > On Fri, 2020-01-17 at 21:14 +0000, Trond Myklebust wrote: > > On Fri, 2020-01-17 at 21:09 +0000, Schumaker, Anna wrote: > > > Hi Olga, > > > > > > On Thu, 2020-01-16 at 14:08 -0500, Olga Kornievskaia wrote: > > > > From: Olga Kornievskaia <kolga@xxxxxxxxxx> > > > > > > Have you done any testing with nconnect and the v4.0 replay caches? I > > > did some > > > digging on the mailing list and found this in one of the cover > > > letters from > > > Trond: "The feature is only enabled for NFSv4.1 and NFSv4.2 for now; > > > I don't > > > feel comfortable subjecting NFSv3/v4 replay caches to this treatment > > > yet." > > > > > > > That comment should be considered obsolete. The current code works hard > > to ensure that we replay using the same connection (or at least the > > same source/dest IP+ports) so that NFSv3/v4.0 DRCs work as expected. > > For that reason we've had NFSv3 support since the feature was merged. > > The NFSv4.0 support was just forgotten. > > Thanks for the explanation! I'll add the patch. What happened to this patch? As far as I can tell, the conclusion of this thread was that it should be applied. --b. > > Anna > > > > > > Thanks, > > > Anna > > > > > > > Signed-off-by: Olga Kornievskaia <kolga@xxxxxxxxxx> > > > > --- > > > > fs/nfs/nfs4client.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c > > > > index 460d625..4df3fb0 100644 > > > > --- a/fs/nfs/nfs4client.c > > > > +++ b/fs/nfs/nfs4client.c > > > > @@ -881,7 +881,7 @@ static int nfs4_set_client(struct nfs_server > > > > *server, > > > > > > > > if (minorversion == 0) > > > > __set_bit(NFS_CS_REUSEPORT, &cl_init.init_flags); > > > > - else if (proto == XPRT_TRANSPORT_TCP) > > > > + if (proto == XPRT_TRANSPORT_TCP) > > > > cl_init.nconnect = nconnect; > > > > > > > > if (server->flags & NFS_MOUNT_NORESVPORT) > > -- > > Trond Myklebust > > Linux NFS client maintainer, Hammerspace > > trond.myklebust@xxxxxxxxxxxxxxx > > > >
