Re: [PATCH v2] nfsd4: add filename to states output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



There's a minor Bug that needs squashing in the code I sent. I'll send a V3. :)
Sorry for the trouble.

Best,
- Achilles
---

On Mon, Apr 20, 2020 at 10:30 AM Achilles Gaikwad <agaikwad@xxxxxxxxxx> wrote:
>
> Add filename to states output for ease of debugging.
>
> Signed-off-by: Achilles Gaikwad <agaikwad@xxxxxxxxxx>
> Signed-off-by: Kenneth Dsouza <kdsouza@xxxxxxxxxx>
> ---
>  fs/nfsd/nfs4state.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index e32ecedece0f..f1cc825ff20b 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -2404,6 +2404,11 @@ static void states_stop(struct seq_file *s, void *v)
>         spin_unlock(&clp->cl_lock);
>  }
>
> +static void nfs4_show_fname(struct seq_file *s, struct nfsd_file *f)
> +{
> +         seq_printf(s, "filename: \"%pD2\"", f->nf_file);
> +}
> +
>  static void nfs4_show_superblock(struct seq_file *s, struct nfsd_file *f)
>  {
>         struct inode *inode = f->nf_inode;
> @@ -2449,6 +2454,8 @@ static int nfs4_show_open(struct seq_file *s, struct nfs4_stid *st)
>
>         nfs4_show_superblock(s, file);
>         seq_printf(s, ", ");
> +       nfs4_show_fname(s, file);
> +       seq_printf(s, ", ");
>         nfs4_show_owner(s, oo);
>         seq_printf(s, " }\n");
>         nfsd_file_put(file);
> @@ -2480,6 +2487,8 @@ static int nfs4_show_lock(struct seq_file *s, struct nfs4_stid *st)
>         nfs4_show_superblock(s, file);
>         /* XXX: open stateid? */
>         seq_printf(s, ", ");
> +       nfs4_show_fname(s, file);
> +       seq_printf(s, ", ");
>         nfs4_show_owner(s, oo);
>         seq_printf(s, " }\n");
>         nfsd_file_put(file);
> @@ -2506,6 +2515,7 @@ static int nfs4_show_deleg(struct seq_file *s, struct nfs4_stid *st)
>         /* XXX: lease time, whether it's being recalled. */
>
>         nfs4_show_superblock(s, file);
> +       nfs4_show_fname(s, file);
>         seq_printf(s, " }\n");
>
>         return 0;
> @@ -2524,6 +2534,7 @@ static int nfs4_show_layout(struct seq_file *s, struct nfs4_stid *st)
>         /* XXX: What else would be useful? */
>
>         nfs4_show_superblock(s, file);
> +       nfs4_show_fname(s, file);
>         seq_printf(s, " }\n");
>
>         return 0;
> --
> 2.25.3
>




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux