Re: [PATCH 3/3] NFSv4: Fix fscache cookie aux_data to ensure change_attr is included

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dave,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on nfs/linux-next]
[also build test WARNING on v5.7-rc1 next-20200415]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Dave-Wysochanski/NFS-Fix-fscache-super_cookie-index_key-from-changing-after-umount/20200416-070856
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> fs/nfs/fscache.c:228:8: warning: return type defaults to 'int' [-Wreturn-type]
     228 | static nfs_fscache_update_auxdata(struct nfs_fscache_inode_auxdata *auxdata,
         |        ^~~~~~~~~~~~~~~~~~~~~~~~~~
   fs/nfs/fscache.c: In function 'nfs_fscache_update_auxdata':
>> fs/nfs/fscache.c:239:1: warning: control reaches end of non-void function [-Wreturn-type]
     239 | }
         | ^

vim +/int +228 fs/nfs/fscache.c

   227	
 > 228	static nfs_fscache_update_auxdata(struct nfs_fscache_inode_auxdata *auxdata,
   229					  struct nfs_inode *nfsi)
   230	{
   231		memset(auxdata, 0, sizeof(*auxdata));
   232		auxdata->mtime_sec  = nfsi->vfs_inode.i_mtime.tv_sec;
   233		auxdata->mtime_nsec = nfsi->vfs_inode.i_mtime.tv_nsec;
   234		auxdata->ctime_sec  = nfsi->vfs_inode.i_ctime.tv_sec;
   235		auxdata->ctime_nsec = nfsi->vfs_inode.i_ctime.tv_nsec;
   236	
   237		if (NFS_SERVER(&nfsi->vfs_inode)->nfs_client->rpc_ops->version == 4)
   238			auxdata->change_attr = inode_peek_iversion_raw(&nfsi->vfs_inode);
 > 239	}
   240	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux