> On Mar 13, 2020, at 8:39 AM, Petr Vorel <pvorel@xxxxxxx> wrote:
>
> It's meant to be read only.
>
> Fixes: 89c905beccbb ("nfsd: allow forced expiration of NFSv4 clients")
>
> Signed-off-by: Petr Vorel <pvorel@xxxxxxx>
> ---
> Hi,
>
> does not really fix anything, it's just confusing to have read
> permission bit when not used.
Hi Petr, applied to nfsd-5.7-testing, with the patch description corrected
to read:
"It's meant to be write-only."
> Kind regards,
> Petr
>
> fs/nfsd/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 65cfe9ab47be..475ece438cfc 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -2636,7 +2636,7 @@ static const struct file_operations client_ctl_fops = {
> static const struct tree_descr client_files[] = {
> [0] = {"info", &client_info_fops, S_IRUSR},
> [1] = {"states", &client_states_fops, S_IRUSR},
> - [2] = {"ctl", &client_ctl_fops, S_IRUSR|S_IWUSR},
> + [2] = {"ctl", &client_ctl_fops, S_IWUSR},
> [3] = {""},
> };
--
Chuck Lever
