Re: [nfs-utils PATCH] locktest: Makefile.am: remove host compiler costraint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Petr,

On 1/19/20 2:10 PM, Petr Vorel wrote:
> Hi,
> 
>> Currently locktest can be built only for host because CC_FOR_BUILD is
>> specified as CC, but this leads to build failure when passing CFLAGS not
>> available on host gcc(i.e. -mlongcalls) and most of all locktest would
>> be available on target systems the same way as rpcgen etc. So remove CC
>> and LIBTOOL assignments.
> 
>> Signed-off-by: Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Petr Vorel <petr.vorel@xxxxxxxxx>
> Tested-by: Petr Vorel <petr.vorel@xxxxxxxxx>
> NOTE: as I understand it's a compilation issue of a tool, so I didn't run
> rpcgen, I just test various compilation variants for buildroot.
Just to be clear... Giulio's patch, removing CC and LIBTOOL from the
locktest/Makefile.am does allows your cross build to succeed, correct?

steved.

> 
> Kind regards,
> Petr
> 
>> ---
>>  tools/locktest/Makefile.am | 3 ---
>>  1 file changed, 3 deletions(-)
> 
>> diff --git a/tools/locktest/Makefile.am b/tools/locktest/Makefile.am
>> index 3156815d..e8914655 100644
>> --- a/tools/locktest/Makefile.am
>> +++ b/tools/locktest/Makefile.am
>> @@ -1,8 +1,5 @@
>>  ## Process this file with automake to produce Makefile.in
> 
>> -CC=$(CC_FOR_BUILD)
>> -LIBTOOL = @LIBTOOL@ --tag=CC
>> -
>>  noinst_PROGRAMS = testlk
>>  testlk_SOURCES = testlk.c
>>  testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
> 




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux