On Thu, 2019-12-19 at 06:49 +1100, Dave Chinner wrote: > > IOWs, This would be much more efficient as: > > fsync(dst) > commit_inode_metadata(src) > > as it would end up as: > > writeback data (dst data) > journal write(src+dst metadata) > > and the call to commit_inode_metadata(src) ends up being a no-op > with almost no overhead... > Thanks Dave! Fixed up in v2. Cheers Trond -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@xxxxxxxxxxxxxxx