On Tue, 2019-12-17 at 16:04 -0500, J. Bruce Fields wrote: > On Tue, Dec 17, 2019 at 08:51:20PM +0000, Trond Myklebust wrote: > > On Tue, 2019-12-17 at 14:30 -0500, J. Bruce Fields wrote: > > > On Tue, Dec 17, 2019 at 12:33:33PM -0500, Trond Myklebust wrote: > > > > We must allow for the fact that iov_iter_write() could have > > > > returned > > > > a short write (e.g. if there was an ENOSPC issue). > > > > > > Thanks! Just a nit: > > > > > > > Fixes: 73da852e3831 ("nfsd: use vfs_iter_read/write") > > > > > > I think that should be d890be159a71 "nfsd: Add I/O trace points > > > in > > > the > > > NFSv4 write path". > > > > Fair enough. Do you want to fix that up? > > I've taken care of it.--b. Thank you! -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@xxxxxxxxxxxxxxx