-On Mon, 2019-12-16 at 18:43 +0000, Robert Milkowski wrote: > > From: Trond Myklebust <trondmy@xxxxxxxxxxxxxxx> > ... > > NACK. The above argument only applies to legacy minor version 0 > > setups, and does not apply to NFSv4.1 or newer. > > Correct. However many sites still use v4.0. > That's not a good reason to break code that works just fine for NFSv4.1. It would be better to move the initialisation of clp->cl_last_renewal into nfs4_init_clientid() and nfs41_init_clientid() (after the calls to nfs4_proc_setclientid_confirm() and nfs4_proc_create_session() respectively). -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@xxxxxxxxxxxxxxx
