Re: [PATCH] nfsd: Ensure CLONE persists data and metadata changes to the target file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2019-11-30 at 14:58 -0500, J. Bruce Fields wrote:
> On Fri, Nov 29, 2019 at 01:53:13AM +0800, kbuild test robot wrote:
> >    fs//nfsd/vfs.c: In function 'nfsd4_clone_file_range':
> > > > fs//nfsd/vfs.c:540:5: error: 'commit_is_datasync' undeclared
> > > > (first use in this function); did you mean 'commit_metadata'?
> ...
> >    539			int status = vfs_fsync_range(dst,
> > dst_pos, dst_end,
> >  > 540					commit_is_datasync);
> 
> I've replaced commit_is_datasync by 0.  Trond, correct me if I got
> that
> wrong.

Doh! Sorry about that. I blame ENOCOFFEE...

Thanks!
  Trond
> 
> --b.
> 
> >    541			if (status < 0)
> >    542				return nfserrno(status);
> >    543		}
> >    544		return 0;
> >    545	}
> >    546	
> > 
> > ---
> > 0-DAY kernel test infrastructure                 Open Source
> > Technology Center
> > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel
> > Corporation
> 
> 
-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@xxxxxxxxxxxxxxx






[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux