On Sun, Sep 22, 2019 at 09:52:36AM +0300, Alex Lyakas wrote: > I do see in the code that a delegation stateid also holds an open > file on the file system. In my experiments, however, the > nfs4_client::cl_delegations list was always empty. I put an extra > print to print a warning if it's not, but did not hit this. Do you know what version of NFS the clients are using? (4.0, 4.1, 4.2?) --b. > > Thanks, > Alex. > > > > -----Original Message----- From: J. Bruce Fields > Sent: Tuesday, September 10, 2019 11:25 PM > To: Alex Lyakas > Cc: linux-nfs@xxxxxxxxxxxxxxx ; Shyam Kaushik > Subject: Re: [RFC-PATCH] nfsd: provide a procfs entry to release > stateids of a particular local filesystem > > On Tue, Sep 10, 2019 at 10:00:24PM +0300, Alex Lyakas wrote: > >I addressed your comments, and ran the patch through checkpatch.pl. > >Patch v2 is on its way. > > Thanks for the revision! I need to spend the next week or so catching > up on some other review and then I'll get back to this. > > For now: > > >On Fri, Sep 6, 2019 at 7:12 PM J. Bruce Fields > ><bfields@xxxxxxxxxxxx> wrote: > >> You'll want to cover delegations as well. And probably pNFS layouts. > >> It'd be OK to do that incrementally in followup patches. > >Unfortunately, I don't have much understanding of what these are, and > >how to cover them) > > Delegations are give the client the right to cache files across opens. > I'm a little surprised your patches are working for you without handling > delegations. There may be something about your environment that's > preventing delegations from being given out. In the NFSv4.0 case they > require the server to make a tcp connection back the client, which is > easy blocked by firewalls or NAT. Might be worth testing with v4.1 or > 4.2. > > Anyway, so we probably also want to walk the client's dl_perclnt list > and look for matching files. > > --b.
