Re: [PATCH v5 9/9] NFSD add nfs4 inter ssc to nfsd4_copy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Olga,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nfsd/nfsd-next]
[cannot apply to v5.3-rc3 next-20190809]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/server-side-support-for-inter-SSC-copy/20190811-120551
base:   git://linux-nfs.org/~bfields/linux.git nfsd-next
config: x86_64-lkp (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from fs//nfsd/state.h:42:0,
                    from fs//nfsd/xdr4.h:40,
                    from fs//nfsd/nfs4proc.c:44:
   fs//nfsd/nfsd.h:391:16: warning: 'struct nfs42_netaddr' declared inside parameter list will not be visible outside of this definition or declaration
            struct nfs42_netaddr *netaddr)
                   ^~~~~~~~~~~~~
   fs//nfsd/nfsd.h: In function 'nfsd4_set_netaddr':
   fs//nfsd/nfsd.h:401:18: error: dereferencing pointer to incomplete type 'struct nfs42_netaddr'
      sprintf(netaddr->netid, "tcp");
                     ^~
   In file included from fs//nfsd/nfs4proc.c:44:0:
   fs//nfsd/xdr4.h: At top level:
   fs//nfsd/xdr4.h:528:20: error: field 'cp_src' has incomplete type
     struct nl4_server cp_src;
                       ^~~~~~
   fs//nfsd/xdr4.h:583:20: error: field 'cpn_dst' has incomplete type
     struct nl4_server cpn_dst;
                       ^~~~~~~
   fs//nfsd/xdr4.h:589:20: error: field 'cpn_src' has incomplete type
     struct nl4_server cpn_src;
                       ^~~~~~~
   fs//nfsd/nfs4proc.c: In function 'dup_copy_fields':
>> fs//nfsd/nfs4proc.c:1446:44: error: invalid application of 'sizeof' to incomplete type 'struct nl4_server'
     memcpy(&dst->cp_src, &src->cp_src, sizeof(struct nl4_server));
                                               ^~~~~~
   fs//nfsd/nfs4proc.c: In function 'nfsd4_copy_notify':
   fs//nfsd/nfs4proc.c:1640:25: error: 'NL4_NETADDR' undeclared (first use in this function); did you mean 'RTM_GETADDR'?
     cn->cpn_src.nl4_type = NL4_NETADDR;
                            ^~~~~~~~~~~
                            RTM_GETADDR
   fs//nfsd/nfs4proc.c:1640:25: note: each undeclared identifier is reported only once for each function it appears in

vim +1446 fs//nfsd/nfs4proc.c

  1431	
  1432	static int dup_copy_fields(struct nfsd4_copy *src, struct nfsd4_copy *dst)
  1433	{
  1434		dst->cp_src_pos = src->cp_src_pos;
  1435		dst->cp_dst_pos = src->cp_dst_pos;
  1436		dst->cp_count = src->cp_count;
  1437		dst->cp_synchronous = src->cp_synchronous;
  1438		memcpy(&dst->cp_res, &src->cp_res, sizeof(src->cp_res));
  1439		memcpy(&dst->fh, &src->fh, sizeof(src->fh));
  1440		dst->cp_clp = src->cp_clp;
  1441		dst->file_dst = get_file(src->file_dst);
  1442		dst->cp_intra = src->cp_intra;
  1443		if (src->cp_intra) /* for inter, file_src doesn't exist yet */
  1444			dst->file_src = get_file(src->file_src);
  1445		memcpy(&dst->cp_stateid, &src->cp_stateid, sizeof(src->cp_stateid));
> 1446		memcpy(&dst->cp_src, &src->cp_src, sizeof(struct nl4_server));
  1447		memcpy(&dst->stateid, &src->stateid, sizeof(src->stateid));
  1448		memcpy(&dst->c_fh, &src->c_fh, sizeof(src->c_fh));
  1449		dst->ss_mnt = src->ss_mnt;
  1450	
  1451		return 0;
  1452	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux