Re: [PATCH 05/16] nfsd: add a new struct file caching facility to nfsd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 05/16] nfsd: add a new struct file caching facility to nfsd
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Sun, 30 Jun 2019 08:57:45 -0700
Cc: "J. Bruce Fields" <bfields@xxxxxxxxxx>, Chuck Lever <chuck.lever@xxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20190630135240.7490-6-trond.myklebust@hammerspace.com>
References: <20190630135240.7490-1-trond.myklebust@hammerspace.com> <20190630135240.7490-2-trond.myklebust@hammerspace.com> <20190630135240.7490-3-trond.myklebust@hammerspace.com> <20190630135240.7490-4-trond.myklebust@hammerspace.com> <20190630135240.7490-5-trond.myklebust@hammerspace.com> <20190630135240.7490-6-trond.myklebust@hammerspace.com>
User-agent: Mutt/1.11.4 (2019-03-13)

On Sun, Jun 30, 2019 at 09:52:29AM -0400, Trond Myklebust wrote:
> +/* FIXME: dynamically size this for the machine somehow? */
> +#define NFSD_FILE_HASH_BITS                   12
> +#define NFSD_FILE_HASH_SIZE                  (1 << NFSD_FILE_HASH_BITS)
> +#define NFSD_LAUNDRETTE_DELAY		     (2 * HZ)

Isn't this what rhashtable is for?

Follow-Ups:
- Re: [PATCH 05/16] nfsd: add a new struct file caching facility to nfsd
  - From: Trond Myklebust

References:
- [PATCH 00/16] Cache open file descriptors in knfsd
  - From: Trond Myklebust
- [PATCH 01/16] sunrpc: add a new cache_detail operation for when a cache is flushed
  - From: Trond Myklebust
- [PATCH 02/16] locks: create a new notifier chain for lease attempts
  - From: Trond Myklebust
- [PATCH 03/16] notify: export symbols for use by the knfsd file cache
  - From: Trond Myklebust
- [PATCH 04/16] vfs: Export flush_delayed_fput for use by knfsd.
  - From: Trond Myklebust
- [PATCH 05/16] nfsd: add a new struct file caching facility to nfsd
  - From: Trond Myklebust

Prev by Date: Re: [PATCH 02/16] locks: create a new notifier chain for lease attempts
Next by Date: Re: [PATCH 05/16] nfsd: add a new struct file caching facility to nfsd
Previous by thread: [PATCH 16/16] nfsd: Fix the documentation for svcxdr_tmpalloc()
Next by thread: Re: [PATCH 05/16] nfsd: add a new struct file caching facility to nfsd
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystem Development] [Linux USB Development] [Linux Media Development] [Video for Linux] [Linux NILFS] [Linux Audio Users] [Yosemite Info] [Linux SCSI]