On Fri, Jun 14, 2019 at 09:52:37PM +0300, Ido Schimmel wrote: > On Wed, Apr 24, 2019 at 05:46:42PM -0400, Trond Myklebust wrote: > > When converting kuids to AUTH_UNIX creds, etc we will want to use the > > same user namespace as the process that created the rpc client. > > > > Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> > > Hi, > > Since upgrading to v5.2-rc1 I started encountering these memory leaks > [1]. Bisection using this reproducer [2] points to this patch. Attached > the full bisection log [3]. > > Please let me know if more information is required. Ping? > > Thanks > > [1] > unreferenced object 0xffffa35dfaea3000 (size 192): > comm "mount", pid 428, jiffies 4294703475 (age 7.578s) > hex dump (first 32 bytes): > 03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [<00000000b43bed74>] prepare_exec_creds+0x6/0x40 > [<00000000422eb980>] __do_execve_file.isra.56+0x124/0x930 > [<00000000aa848639>] __x64_sys_execve+0x2f/0x40 > [<000000008d5c43e1>] do_syscall_64+0x43/0xf0 > [<0000000068b03b0e>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 > [<000000001fab781f>] 0xffffffffffffffff > > [2] > #!/bin/bash > > umount /mnt/share155 > mount -t nfs <nfs-server>:/images/share /mnt/share155 > echo scan > /sys/kernel/debug/kmemleak > cat /sys/kernel/debug/kmemleak > > [3] > git bisect start > # good: [e93c9c99a629c61837d5a7fc2120cd2b6c70dbdd] Linux 5.1 > git bisect good e93c9c99a629c61837d5a7fc2120cd2b6c70dbdd > # bad: [a188339ca5a396acc588e5851ed7e19f66b0ebd9] Linux 5.2-rc1 > git bisect bad a188339ca5a396acc588e5851ed7e19f66b0ebd9 > # good: [2646719a48c21ba0cae82a3f57382a9573fd8400] Merge tag 'kbuild-v5.2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild > git bisect good 2646719a48c21ba0cae82a3f57382a9573fd8400 > # bad: [b970afcfcabd63cd3832e95db096439c177c3592] Merge tag 'powerpc-5.2-1' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/powerpc/linux > git bisect bad b970afcfcabd63cd3832e95db096439c177c3592 > # good: [eb85d03e01c3e9f3b0ba7282b2e3515a635decb2] Merge tag 'drm-misc-next-fixes-2019-05-08' of git://anongit.freedesktop.org/drm/drm-misc into drm-next > git bisect good eb85d03e01c3e9f3b0ba7282b2e3515a635decb2 > # good: [dce45af5c2e9e85f22578f2f8065f225f5d11764] Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma > git bisect good dce45af5c2e9e85f22578f2f8065f225f5d11764 > # bad: [8e4ff713ce313dcabbb60e6ede1ffc193e67631f] Merge tag 'rtc-5.2' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux > git bisect bad 8e4ff713ce313dcabbb60e6ede1ffc193e67631f > # bad: [45182e4e1f8ac04708ca7508c51d9103f07d81ab] Merge branch 'i2c/for-5.2' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux > git bisect bad 45182e4e1f8ac04708ca7508c51d9103f07d81ab > # bad: [5940d1cf9f42f67e9cc3f7df9eda39f5888d6e9e] SUNRPC: Rebalance a kref in auth_gss.c > git bisect bad 5940d1cf9f42f67e9cc3f7df9eda39f5888d6e9e > # good: [23146500b32fbee7eaa57c5002fcd64e5d9b32ca] xprtrdma: Clean up rpcrdma_create_rep() and rpcrdma_destroy_rep() > git bisect good 23146500b32fbee7eaa57c5002fcd64e5d9b32ca > # good: [2cfd11f16f01c0ee8f83bb07027c9d2f43565473] xprtrdma: Remove stale comment > git bisect good 2cfd11f16f01c0ee8f83bb07027c9d2f43565473 > # bad: [b422df915cef80333d7a1732e6ed81f41db12b79] lockd: Store the lockd client credential in struct nlm_host > git bisect bad b422df915cef80333d7a1732e6ed81f41db12b79 > # bad: [ac83228a7101e655ba5a7fa61ae10b058ada15db] SUNRPC: Use namespace of listening daemon in the client AUTH_GSS upcall > git bisect bad ac83228a7101e655ba5a7fa61ae10b058ada15db > # bad: [1a58e8a0e5c1f188a80eb9e505bc77d78a31a4ec] NFS: Store the credential of the mount process in the nfs_server > git bisect bad 1a58e8a0e5c1f188a80eb9e505bc77d78a31a4ec > # bad: [79caa5fad47c69874f9efc4ac3128cc3f6d36f6e] SUNRPC: Cache cred of process creating the rpc_client > git bisect bad 79caa5fad47c69874f9efc4ac3128cc3f6d36f6e > # first bad commit: [79caa5fad47c69874f9efc4ac3128cc3f6d36f6e] SUNRPC: Cache cred of process creating the rpc_client
