> On Jun 13, 2019, at 8:03 AM, Dave Wysochanski <dwysocha@xxxxxxxxxx> wrote:
>
> Add explicit check for statsvers instead of array based check.
Hi Dave,
I don't understand why this change is necessary. The patch description
should explain.
> Signed-off-by: Dave Wysochanski <dwysocha@xxxxxxxxxx>
> ---
> tools/mountstats/mountstats.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
> index 5f13bf8e..2ebbf945 100755
> --- a/tools/mountstats/mountstats.py
> +++ b/tools/mountstats/mountstats.py
> @@ -476,7 +476,7 @@ class DeviceData:
> if retrans != 0:
> print('\t%d retrans (%d%%)' % (retrans, ((retrans * 100) / count)), end=' ')
> print('\t%d major timeouts' % stats[3], end='')
> - if len(stats) >= 10 and stats[9] != 0:
> + if self.__rpc_data['statsvers'] >= 1.1 and stats[9] != 0:
> print('\t%d errors (%d%%)' % (stats[9], ((stats[9] * 100) / count)))
> else:
> print('')
> --
> 2.20.1
>
--
Chuck Lever
