On 10 Jun 2019, at 12:43, Trond Myklebust wrote: > On Mon, 2019-06-10 at 10:14 -0400, Benjamin Coddington wrote: >> On 4 Jun 2019, at 15:00, Benjamin Coddington wrote: >> >>> At least now I can spend some time on it and not feel aimless, >>> thanks for >>> the closer look. >> >> I am not finding a reliable way to fix this and retain the >> optimization. I >> will send a patch to remove it. > > > How about just moving the optimisation into the if > (nfs_check_verifier()) { } case? There should be no need to do the > nfs_lookup_verify_inode() dance if we hold a delegation. should there? Ok, right -- we can optimize that away.. I'll see what sticks to the wall. Ben