On 24 May 2019, at 12:47, J. Bruce Fields wrote:
On Thu, May 23, 2019 at 10:45:43AM -0400, Benjamin Coddington wrote:
This series aims to correct the fl_pid value for locks held by the
NLM
server, or lockd. It applies onto the revert of the previous attempt
to fix
this problem sent ealier this week: '[PATCH] Revert "lockd: Show pid
of
lockd for remote locks"'.
The problem with the earlier attempt was that we discarded the svid,
and so
we couldn't distinguish remote lockowners on each host. It is
necessary to
turn the svid and host into a distinct owner.
So, to make sure I understand, we've got multiple ways to identify a
lock owner:
- the svid, the pid of the client process: this gets returned to
the client in grant callbacks and (possibly to a different
client) in testd results.
- the pid of the server's lockd process: this is what other
processes on the server see as the owner of locks held by nfs
clients.
- the nlm_lockowner: a (nlm_host, svid) pair, used to actually
decide when locks conflict.
That's it.
Makes sense to me.
I'll send your earlier revert to stable, then add this on top for the
5.3 merge window. Sound OK?
Sounds great, thank you!
Ben
