On 17 May 2019, at 17:45, Xuewei Zhang wrote: > Seems this patch introduced a bug in how lock protocol handles > GRANTED_MSG in nfs. Yes, you're right: it's broken, and broken badly because we find conflicting locks based on lockd's fl_pid and lockd's fl_owner, which is current->files. That means that clients are not differentiated, and that means that v3 locks are broken. I'd really like to see the fl_pid value make sense on the server when we show it to userspace, so I think that we should stuff the svid in fl_owner. Clearly I need to be more careful making changes here, so I am going to take my time fixing this, and I won't get to it until Monday. A revert would get us back to safe behavior. Ben
