Re: [PATCH] nfs-utils: nfsidmap fail to build if no --with-pluginpath specified

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On 4/2/19 5:16 AM, Yongcheng Yang wrote:
> The var "pkgplugindir" will be empty if no pluginpath provided.
> Makefile "-rpath $(pkgplugindir)" will then get failed.
> 
> Signed-off-by: Yongcheng Yang <yongcheng.yang@xxxxxxxxx>
> ---
>  support/nfsidmap/Makefile.am | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/support/nfsidmap/Makefile.am b/support/nfsidmap/Makefile.am
> index cdbeb4c..9c21fa3 100644
> --- a/support/nfsidmap/Makefile.am
> +++ b/support/nfsidmap/Makefile.am
> @@ -1,4 +1,8 @@
> +if PATH_PLUGINS
>  pkgplugindir=$(PATH_PLUGINS)
> +else
> +pkgplugindir=$(libdir)/libnfsidmap
> +endif
>  
>  if ENABLE_LDAP
>  UMICH_LDAP_LIB = umich_ldap.la
> 
The only way I see a failure is when ./configure --with-pluginpath= 
without a path which is wrong... 

./configure --with-pluginpath=/usr/lib/libnfsidmap seems to work
just fine

I thinking it is better to error out when a path is not given
then to gloss over but used a default.

steved.




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux