On Mon, 2019-04-08 at 13:11 -0400, Anna Schumaker wrote: > On Sat, 2019-04-06 at 14:14 +0000, Trond Myklebust wrote: > > Hi Anna > > > > On Fri, 2019-04-05 at 15:42 -0400, Anna Schumaker wrote: > > > Hi Trond, > > > > > > I'm having some trouble with xfstests generic/464 after applying > > > this > > > patch. > > > Here is the oops I'm getting, I'm able to reproduce it fairly > > > easily > > > against all > > > NFS versions: > > > > > > [ 41.182015] BUG: unable to handle kernel NULL pointer > > > dereference > > > at > > > 0000000000000048 > > > [ 41.182051] #PF error: [normal kernel read fault] > > > [ 41.182071] PGD 0 P4D 0 > > > [ 41.182086] Oops: 0000 [#1] PREEMPT SMP PTI > > > [ 41.182104] CPU: 1 PID: 14515 Comm: kworker/1:6 Not tainted > > > 5.1.0- > > > rc3-ANNA+ > > > #5292 > > > [ 41.182131] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 > > > [ 41.182174] Workqueue: nfsiod rpc_async_release [sunrpc] > > > [ 41.182209] RIP: 0010:__put_nfs_open_context+0xd/0x110 [nfs] > > > [ 41.182227] Code: f8 ba a8 00 00 00 be c0 0c 00 00 e8 5d c0 58 > > > f7 > > > 48 89 c3 48 > > > 85 c0 74 c5 e9 15 ff ff ff 0f 1f 44 00 00 41 56 41 55 41 54 55 53 > > > <48> 8b 47 48 > > > 48 8b 68 30 4c 8b 60 68 f0 ff 0f 0f 88 14 53 01 00 74 > > > [ 41.182267] RSP: 0018:ffffae5f04b6be30 EFLAGS: 00010246 > > > [ 41.182279] RAX: 0000000000000000 RBX: ffffa22aae71a680 RCX: > > > 0000000000000000 > > > [ 41.182295] RDX: ffffffffb9205dc8 RSI: 0000000000000000 RDI: > > > 0000000000000000 > > > [ 41.182311] RBP: 0000000000000801 R08: ffffa22aa5ca0000 R09: > > > ffffa22aba267800 > > > [ 41.182327] R10: 0000000000000000 R11: 0000000000000000 R12: > > > ffffce5effd1c200 > > > [ 41.182351] R13: 0000000000000000 R14: ffffa22aad2aa6c0 R15: > > > 0ffffce5effd1c20 > > > [ 41.182378] FS: 0000000000000000(0000) > > > GS:ffffa22abcb00000(0000) > > > knlGS:0000000000000000 > > > [ 41.182411] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > [ 41.182435] CR2: 0000000000000048 CR3: 00000000af972005 CR4: > > > 0000000000160ee0 > > > [ 41.182468] Call Trace: > > > [ 41.182495] nfs_commitdata_release+0x15/0x30 [nfs] > > > [ 41.182536] rpc_free_task+0x39/0x70 [sunrpc] > > > [ 41.182571] rpc_async_release+0x29/0x40 [sunrpc] > > > [ 41.182594] process_one_work+0x1eb/0x410 > > > [ 41.182611] worker_thread+0x2d/0x3d0 > > > [ 41.182621] ? process_one_work+0x410/0x410 > > > [ 41.182632] kthread+0x112/0x130 > > > [ 41.182641] ? kthread_park+0x80/0x80 > > > [ 41.182652] ret_from_fork+0x35/0x40 > > > [ 41.182662] Modules linked in: nfsv3 nfs fscache rpcrdma > > > ib_isert > > > > > > > Does the following patch help to fix this? > > This patch does fix the problem. Thanks! > Cool! I sent a v3 patchset update last night with this patch correctly positioned so it won't cause bisection issues, and with 2 other bugfixes. Hopefully, that is the final iteration of the patchset. -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@xxxxxxxxxxxxxxx
