On Fri, Mar 29, 2019 at 08:16:09AM -0400, Scott Mayhew wrote: > On Thu, 28 Mar 2019, J. Bruce Fields wrote: > > Thanks! It looks good to me on a first skim, but I probably won't get a > > proper look at it till next week. > > > > You say "RFC"--are there still known issue that you're working on? > > No, I just added RFC because of the new stuff I added for handling the > legacy records. Plus I wasn't sure if you would have a problem with the > server not lifting the grace period early if there were legacy records. > I could do it if I moved some code out of nfs4recover.c but I chose not > to since it should really be a one-time thing and the original legacy > tracking didn't lift the grace period early anyway. Yeah, I don't think that case is worth spending time optimizing. The kernel patches look OK to me. I'm inclined to target them for the next merge window (5.2). If Jeff has the time to take a look, it'd also be good to know if he has any more concerns. --b.
