Re: [PATCH] SUNRPC: remove pointless test in unx_match()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2019-01-07 at 17:53 +1100, NeilBrown wrote:
> As reported by Dan Carpenter, this test for acred->cred being set is
> inconsistent with the dereference of the pointer a few lines earlier.
> 
> An 'auth_cred' *always* has ->cred set - every place that creates one
> initializes this field, often as the first thing done.
> 
> So remove this test.
> 
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: NeilBrown <neilb@xxxxxxxx>
> 

Thanks Neil! Applied to the linux-next branch for inclusion in the 5.1
merge window.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@xxxxxxxxxxxxxxx






[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux