On 28 Jan 2019, at 12:59, Trond Myklebust wrote: > Hi Ben > > We were apparently both looking at the same code last week ☺. I have a > similar patch, but that also fixes a similar clobbering issue with the > nfs_error_is_fatal() error just a few lines further down. > > Without the extra hunk, we could end up converting an interrupted call > into a 'successful' write. > > Cheers > Trond Looks right to me. I hope you'll take the Fixes and stable version from my patch, which will cover the problem I'm seeing. Reviewed-by: Benjamin Coddington <bcodding@xxxxxxxxxx> Ben