> On Jan 5, 2019, at 8:06 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> This should return -ENOMEM if __alloc_workqueue_key() fails, but it
> returns success.
>
> Fixes: 6d2d0ee27c7a ("xprtrdma: Replace rpcrdma_receive_wq with a per-xprt workqueue")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Indeed.
Reviewed-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
> ---
> net/sunrpc/xprtrdma/verbs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
> index 7749a2bf6887..3dde05892c8e 100644
> --- a/net/sunrpc/xprtrdma/verbs.c
> +++ b/net/sunrpc/xprtrdma/verbs.c
> @@ -1113,8 +1113,10 @@ rpcrdma_buffer_create(struct rpcrdma_xprt *r_xprt)
> WQ_MEM_RECLAIM | WQ_HIGHPRI,
> 0,
> r_xprt->rx_xprt.address_strings[RPC_DISPLAY_ADDR]);
> - if (!buf->rb_completion_wq)
> + if (!buf->rb_completion_wq) {
> + rc = -ENOMEM;
> goto out;
> + }
>
> return 0;
> out:
> --
> 2.17.1
>
--
Chuck Lever
