On 12/21/18 2:30 PM, Vasily Averin wrote: > On 12/21/18 4:00 AM, bfields@xxxxxxxxxxxx wrote: >> On Tue, Dec 18, 2018 at 02:55:15PM +0000, Trond Myklebust wrote: >>> No. We don't care about xpt_flags for the back channel because there is >>> no "server transport". The actual transport is stored in the 'struct >>> rpc_rqst', and is the struct rpc_xprt corresponding to the client >>> socket or RDMA channel. >>> >>> IOW: All we really need in svc_process_common() is to be able to run >>> rqstp->rq_xprt->xpt_ops->xpo_prep_reply_hdr(), and that can be passed >>> either as a pointer to the struct svc_xprt_ops itself. >> >> For what it's worth, I'd rather get rid of that op--it's an awfully >> roundabout way just to do "svc_putnl(resv, 0);" in the tcp case. > > I'll try to save pointer to xpt_ops on per-netns sunrpc_net, > and use it in svc_process_common() if rqstp->rq_xprt == NULL. Bruce, Trond, I've send v3 patch version, and waiting for your feedback. Thank you, Vasily Averin
